Fix/1542 oauth validation logs #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crivetimihai
force-pushed
the
fix/1542-oauth-validation-logs
branch
from
66fcaba to
1abe893
Compare
… limit - Increase default validation_max_json_depth from 10 to 30 for compatibility with deeply nested schemas (e.g., Notion MCP) - Add VALIDATION_MAX_JSON_DEPTH environment variable for configuration - Add _validate_tools method for per-tool validation with detailed error logging instead of silent failures - Add OAuthToolValidationError for OAuth-specific validation failures - Provide helpful error messages suggesting depth limit increase - Add exclude_unset=True to model_dump to prevent validation issues Users will now see actionable error messages instead of generic "unhandled errors in TaskGroup" when tool validation fails. Closes IBM#1542 Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
force-pushed
the
fix/1542-oauth-validation-logs
branch
from
1abe893 to
fa26192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
researched issue #1542 and found that Notion MCP schemas exceed the default JSON depth limit. Here's what I implemented:
Solution:
VALIDATION_MAX_JSON_DEPTHResult: Users will now see helpful error messages instead of "unhandled errors in TaskGroup", and Notion MCP should work out-of-the-box.
Looking forward to your review of these changes!